Use Testcontainers Typesense module#81
Open
eddumelendez wants to merge 2 commits intotypesense:masterfrom
Open
Use Testcontainers Typesense module#81eddumelendez wants to merge 2 commits intotypesense:masterfrom
eddumelendez wants to merge 2 commits intotypesense:masterfrom
Conversation
Current tests depend on an running instance of Typesense. Adding Testcontainers, test will start and stop the Typesense instance as part of the test lifecycle. Enabling local and CI/CD executions to have the same environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current tests depend on an running instance of Typesense. Adding
Testcontainers, test will start and stop the Typesense instance
as part of the test lifecycle. Enabling local and CI/CD executions
to have the same environment.
Current approach will run one container per test, getting a clean instance. It can also run on instance combine with test suites in JUnit Jupiter 5.11.0.